Fix kanagawa theme when using cursorline #10500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
A-theme
pascalkuthe
approved these changes
Apr 17, 2024
the-mikedavis
approved these changes
Apr 17, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
Chirikumbrah
pushed a commit
to Chirikumbrah/helix
that referenced
this pull request
Jun 15, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to increase the contrast of the primary selection background (#10094) was a good idea - previously the contrast was way too low and I'd often be sat squinting at my monitor.
Unfortunately the new ui.selection.primary colour happens to match exactly the colour used by the cursorline. On top of this, the colour
sumiInk5is just a duplicate ofsumiInk3.This pull request chooses another contrastic colour (specifically
waveBlue2) that doesn't clash with the cursorline and removes thesumiInk5variant:Previously:
(Highlighted line is completely invisible because of the cursorline)
Now:
Paging @mxpv and @zetashift for visibility